On Fri, Mar 3, 2023 at 1:33 PM Christian Hewitt <christianshewitt@xxxxxxxxx> wrote: > > Playing media with a resolution smaller than the crtc size requires the > video overlay to be scaled for output and GXM boards display a 1px pink > line on the bottom of the scaled overlay. Comparing with the downstream > vendor driver revealed VPP_DUMMY_DATA not being set [0]. > > Setting VPP_DUMMY_DATA prevents the 1px pink line from being seen. > > [0] https://github.com/endlessm/linux-s905x/blob/master/drivers/amlogic/amports/video.c#L7869 > > Fixes: bbbe775ec5b5 ("drm: Add support for Amlogic Meson Graphic Controller") > Suggested-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> > Signed-off-by: Christian Hewitt <christianshewitt@xxxxxxxxx> Acked-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> > --- > Change since v1: > This time I sent the right patch from the correct branch; the wording in > v1 is incorrect and the change to meson_registers.h is not required. Thanks Christian - I was about to ask whether you could isolate which part of the original patch fixes the issue, but you've been quicker :-)