Re: [PATCH v15 02/16] drm: exynos: dsi: Lookup OF-graph or Child node devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/3/23 15:51, Jagan Teki wrote:

[...]

--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -1470,18 +1470,52 @@ static int exynos_dsi_host_attach(struct mipi_dsi_host *host,
  	struct device *dev = dsi->dev;
  	struct drm_encoder *encoder = &dsi->encoder;
  	struct drm_device *drm = encoder->dev;
+	struct device_node *np = dev->of_node;
+	struct device_node *remote;
  	struct drm_panel *panel;
  	int ret;
- panel = of_drm_find_panel(device->dev.of_node);
+	/**

This shouldn't be kerneldoc style comment, drop that extra asterisk (*).

+	 * Devices can also be child nodes when we also control that device
+	 * through the upstream device (ie, MIPI-DCS for a MIPI-DSI device).

[...]

With that fixed:

Reviewed-by: Marek Vasut <marex@xxxxxxx>



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux