On 02/03/2023 14:35, Yassine Oudjana wrote: > From: Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx> > > Several DT bindings of MediaTek display blocks make unnecessary use of > "oneOf" and "items", and have some enums with only 1 element. Remove > unnecessary "oneOf" and "items", and replace enums that have 1 element > with "const". > > Signed-off-by: Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx> > --- > .../bindings/display/mediatek/mediatek,aal.yaml | 3 +-- > .../display/mediatek/mediatek,ccorr.yaml | 10 ++++------ > .../display/mediatek/mediatek,color.yaml | 10 ++++------ > .../display/mediatek/mediatek,dither.yaml | 3 +-- > .../bindings/display/mediatek/mediatek,dsc.yaml | 4 +--- > .../display/mediatek/mediatek,gamma.yaml | 7 +++---- > .../display/mediatek/mediatek,merge.yaml | 8 +++----- > .../bindings/display/mediatek/mediatek,od.yaml | 8 +++----- > .../display/mediatek/mediatek,ovl-2l.yaml | 10 ++++------ > .../bindings/display/mediatek/mediatek,ovl.yaml | 16 ++++++---------- > .../display/mediatek/mediatek,postmask.yaml | 3 +-- > .../bindings/display/mediatek/mediatek,rdma.yaml | 13 +++++-------- > .../display/mediatek/mediatek,split.yaml | 4 +--- > .../bindings/display/mediatek/mediatek,ufoe.yaml | 4 +--- > .../bindings/display/mediatek/mediatek,wdma.yaml | 4 +--- > 15 files changed, 39 insertions(+), 68 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml > index 92741486c24d..d8d78abd6c6c 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml > @@ -25,8 +25,7 @@ properties: > - mediatek,mt8173-disp-aal > - mediatek,mt8183-disp-aal > - items: > - - enum: > - - mediatek,mt2712-disp-aal > + - const: mediatek,mt2712-disp-aal This was I think intentional - it will grow. The same in all other one-enum cases, it might be unnecessary change which soon will be reverted converting back to enum. > - const: mediatek,mt8173-disp-aal > - items: > - enum: > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml > index b04820c95b22..e72d2884bb49 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml > @@ -21,18 +21,16 @@ description: | > properties: > compatible: > oneOf: > - - items: > - - const: mediatek,mt8183-disp-ccorr > - - items: > - - const: mediatek,mt8192-disp-ccorr > + - enum: > + - mediatek,mt8183-disp-ccorr > + - mediatek,mt8192-disp-ccorr Such changes are fine. Best regards, Krzysztof
