On 3/1/23 21:54, Rob Clark wrote: > /* virtgpu_display.c */ > +#if defined(CONFIG_DRM_VIRTIO_GPU_KMS) > int virtio_gpu_modeset_init(struct virtio_gpu_device *vgdev); > void virtio_gpu_modeset_fini(struct virtio_gpu_device *vgdev); > +#else > +static inline int virtio_gpu_modeset_init(struct virtio_gpu_device *vgdev) > +{ > + return 0; > +} > +static inline void virtio_gpu_modeset_fini(struct virtio_gpu_device *vgdev) > +{ > +} > +#endif In v4 Gerd wanted to keep building the virtgpu_display.o and instead add the KSM config check to virtio_gpu_modeset_init/fini(). Is there any reason why you didn't do that? -- Best regards, Dmitry