On Tue, 28 Feb 2023 12:32:04 +0000
Simon Ser <contact@xxxxxxxxxxx> wrote:
> Add docs for "{left,right,top,bottom} margin" properties.
>
> v2:
> - Mention the purpose: mitigate underscan on TVs
> - Move out of analog TV section into standard props (Pekka)
> - Mention HDMI AVI InfoFrames (Pekka, Ville)
>
> Signed-off-by: Simon Ser <contact@xxxxxxxxxxx>
> Cc: Maxime Ripard <maxime@xxxxxxxxxx>
> Cc: Daniel Vetter <daniel@xxxxxxxx>
> Cc: Pekka Paalanen <ppaalanen@xxxxxxxxx>
> Cc: Noralf Trønnes <noralf@xxxxxxxxxxx>
> Cc: Mateusz Kwiatkowski <kfyatek+publicgit@xxxxxxxxx>
> Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/drm_connector.c | 18 ++++++++++++++----
> 1 file changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
> index ffd65eddce42..a180f541736a 100644
> --- a/drivers/gpu/drm/drm_connector.c
> +++ b/drivers/gpu/drm/drm_connector.c
> @@ -1446,6 +1446,20 @@ static const struct drm_prop_enum_list dp_colorspaces[] = {
> * a firmware handled hotkey. Therefor userspace must not include the
> * privacy-screen sw-state in an atomic commit unless it wants to change
> * its value.
> + *
> + * left margin, right margin, top margin, bottom margin:
> + * Add margins to the connector's viewport. This is typically used to
> + * mitigate underscan on TVs.
I think it's overscan: scanning over and beyond the phosphor grid.
> + *
> + * The value is the size in pixels of the black border which will be
> + * added. The attached CRTC's content will be scaled to fill the whole
> + * area inside the margin.
> + *
> + * The margins configuration might be sent to the sink, e.g. via HDMI AVI
> + * InfoFrames.
> + *
> + * Drivers can set up these properties by calling
> + * drm_mode_create_tv_margin_properties().
> */
>
> int drm_connector_create_standard_properties(struct drm_device *dev)
> @@ -1590,10 +1604,6 @@ EXPORT_SYMBOL(drm_connector_attach_dp_subconnector_property);
>
> /*
> * TODO: Document the properties:
> - * - left margin
> - * - right margin
> - * - top margin
> - * - bottom margin
> * - brightness
> * - contrast
> * - flicker reduction
With that one typo'ish fixed:
Acked-by: Pekka Paalanen <pekka.paalanen@xxxxxxxxxxxxx>
Thanks,
pq
Attachment:
pgph6fln3E3AF.pgp
Description: OpenPGP digital signature
