Re: [PATCH v2 1/2] drm/vc4: replace drm_gem_dma_object for drm_gem_object in vc4_exec_info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Maíra Canal <mcanal@xxxxxxxxxx> writes:

Hello Maíra,

> The array of BOs that are lookup at the start of exec doesn't need
> to be instantiated as drm_gem_dma_object, as it doesn't benefit
> from its attributes. So, simplify the code by replacing the array of
> drm_gem_dma_object for an array of drm_gem_object in the struct
> vc4_exec_info.
>
> Suggested-by: Melissa Wen <mwen@xxxxxxxxxx>
> Signed-off-by: Maíra Canal <mcanal@xxxxxxxxxx>
> Reviewed-by: André Almeida <andrealmeid@xxxxxxxxxx>
> ---

The change looks good to me and it certainly makes the code simpler.

Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat





[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux