Re: [PATCH 1/2] Mips: ls2k1000: dts: add the display controller device node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 22/02/2023 17:55, suijingfeng wrote:
> The display controller is a pci device, it's pci vendor id is
> 0x0014, it's pci device id is 0x7a06.
> 
> Signed-off-by: suijingfeng <suijingfeng@xxxxxxxxxxx>
> ---
>  .../boot/dts/loongson/loongson64-2k1000.dtsi  | 21 +++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
> index 8143a61111e3..a528af3977d9 100644
> --- a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
> +++ b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
> @@ -31,6 +31,18 @@ memory@200000 {
>  			<0x00000001 0x10000000 0x00000001 0xb0000000>; /* 6912 MB at 4352MB */
>  	};
>  
> +	reserved-memory {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		display_reserved: framebuffer@30000000 {
> +			compatible = "shared-dma-pool";
> +			reg = <0x0 0x30000000 0x0 0x04000000>; /* 64M */
> +			linux,cma-default;
> +		};
> +	};
> +
>  	cpu_clk: cpu_clk {
>  		#clock-cells = <0>;
>  		compatible = "fixed-clock";
> @@ -198,6 +210,15 @@ sata@8,0 {
>  				interrupt-parent = <&liointc0>;
>  			};
>  
> +			display-controller@6,0 {
> +				compatible = "loongson,ls2k1000-dc";
> +
> +				reg = <0x3000 0x0 0x0 0x0 0x0>;
> +				interrupts = <28 IRQ_TYPE_LEVEL_LOW>;
> +				interrupt-parent = <&liointc0>;
> +				memory-region = <&display_reserved>;

NAK. Test your code against the bindings you send. It's the same
patchset. You basically send something which the same moment is incorrect.

Best regards,
Krzysztof




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux