Re: [PATCH] dt-bindings: display: Start the info graphics with HS/VS change

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marek.

On Tue, Feb 21, 2023 at 09:04:07PM +0100, Marek Vasut wrote:
> The VS signal change is synchronized to HS signal change, start the
> info graphics with that event, instead of having that event occur in
> the middle of it.
> 
> Scope trace of DPI bus with HS/VS active HIGH looks as follows:
>          ________________...__
> VS...___/__         __        \______...
> HS...___/  \_______/  \__...__/  \___...
>         ^                        ^
> 	|                        |
>         |    Used to start here -'
> 	|
> 	'--- Start info graphics here
> 
> Signed-off-by: Marek Vasut <marex@xxxxxxx>

I recall being annoyed about this before.
Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx>

> ---
> Cc: Daniel Vetter <daniel@xxxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> ---
>  .../bindings/display/panel/panel-timing.yaml  | 46 +++++++++----------
>  1 file changed, 23 insertions(+), 23 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-timing.yaml b/Documentation/devicetree/bindings/display/panel/panel-timing.yaml
> index 0d317e61edd8f..aea69b84ca5d8 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-timing.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-timing.yaml
> @@ -17,29 +17,29 @@ description: |
>  
>    The parameters are defined as seen in the following illustration.
>  
> -  +----------+-------------------------------------+----------+-------+
> -  |          |        ^                            |          |       |
> -  |          |        |vback_porch                 |          |       |
> -  |          |        v                            |          |       |
> -  +----------#######################################----------+-------+
> -  |          #        ^                            #          |       |
> -  |          #        |                            #          |       |
> -  |  hback   #        |                            #  hfront  | hsync |
> -  |   porch  #        |       hactive              #  porch   |  len  |
> -  |<-------->#<-------+--------------------------->#<-------->|<----->|
> -  |          #        |                            #          |       |
> -  |          #        |vactive                     #          |       |
> -  |          #        |                            #          |       |
> -  |          #        v                            #          |       |
> -  +----------#######################################----------+-------+
> -  |          |        ^                            |          |       |
> -  |          |        |vfront_porch                |          |       |
> -  |          |        v                            |          |       |
> -  +----------+-------------------------------------+----------+-------+
> -  |          |        ^                            |          |       |
> -  |          |        |vsync_len                   |          |       |
> -  |          |        v                            |          |       |
> -  +----------+-------------------------------------+----------+-------+
> +  +-------+----------+-------------------------------------+----------+
> +  |       |          |        ^                            |          |
> +  |       |          |        |vsync_len                   |          |
> +  |       |          |        v                            |          |
> +  +-------+----------+-------------------------------------+----------+
> +  |       |          |        ^                            |          |
> +  |       |          |        |vback_porch                 |          |
> +  |       |          |        v                            |          |
> +  +-------+----------#######################################----------+
> +  |       |          #        ^                            #          |
> +  |       |          #        |                            #          |
> +  | hsync |  hback   #        |                            #  hfront  |
> +  |  len  |   porch  #        |       hactive              #  porch   |
> +  |<----->|<-------->#<-------+--------------------------->#<-------->|
> +  |       |          #        |                            #          |
> +  |       |          #        |vactive                     #          |
> +  |       |          #        |                            #          |
> +  |       |          #        v                            #          |
> +  +-------+----------#######################################----------+
> +  |       |          |        ^                            |          |
> +  |       |          |        |vfront_porch                |          |
> +  |       |          |        v                            |          |
> +  +-------+----------+-------------------------------------+----------+
>  
>  
>    The following is the panel timings shown with time on the x-axis.
> -- 
> 2.39.1



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux