On 2023.02.16 22:32:33 -0800, Randy Dunlap wrote: > Hi, > > On 2/16/23 17:52, Zhenyu Wang wrote: > > On 2023.02.14 20:45:33 -0800, Randy Dunlap wrote: > >> Inserting a Kconfig symbol that does not have a dependency (DRM_I915_GVT) > >> into a list of other symbols that do have a dependency (on DRM_I915) > >> breaks the driver menu presentation in 'make *config'. > >> > > > > I'm not sure what's the actual failure in presentation, I'm not quite familiar > > with Kconfig, could you help to elaborate? > > > > thanks! > > For menuconfig and nconfig, it's a subtle difference. The following menu > items are indented more after the patch (i.e., they are not indented enough > before the patch): > > │ <M> Enable KVM host support Intel GVT-g graphics virtualization │ > │ [*] Enable Intel PXP support │ > │ drm/i915 Debugging ---> │ > │ drm/i915 Profile Guided Optimisation ---> > > Same menu items for gconfig: they should all be subordinate (so indented) > to the main > <M> Intel 8xx/9xx/G3x/G4x/HD Graphics > menu. > > For xconfig, it's worse. "drm/i915 Debugging" and "drm/i915 Profile Guided Optimisation" > are shown on the left side window, while are of the other i915 options are shown in the > right side window (before the patch). > After the patch, all subordinate options are listed in the right side window under the > main "Intel 8xx/9xx/G3x/G4x/HD Graphics" menu item. > > See attached photos for comparisons. > I wasn't awared of the wrong indentation. Thanks a lot, Randy! Acked-by: Zhenyu Wang <zhenyuw@xxxxxxxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
