Re: [PATCH 1/6] drm/atomic-helper: Add atomic_enable plane-helper callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thomas Zimmermann <tzimmermann@xxxxxxx> writes:

> Add atomic_enable to struct drm_plane_helper_funcs. It enables a
> plane independently from updating the plane's content. As such, it is
> the inverse of the atomic_disable plane helper. Useful for hardware
> where plane enable state is independent from plane content.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> ---

Thanks a lot for adding this. I remember wanting a plane .atomic_enable in
the past, and due not having one ended adding the enable/disable logic in
the encoder .atomic_{en,dis}able callbacks instead.

>From my understanding of the atomic state helpers the patch looks good to me.

Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>

Best regards,
Javier




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux