On Thu, Feb 16, 2023 at 12:28 PM Stanislaw Gruszka <stanislaw.gruszka@xxxxxxxxxxxxxxx> wrote: > > Hi > > On Sun, Feb 12, 2023 at 10:44:45PM +0200, Oded Gabbay wrote: > > > irqreturn_t hl_irq_handler_user_interrupt(int irq, void *arg) > > +{ > > + return IRQ_WAKE_THREAD; > > +} > > This is not needed. You can pass NULL to request_threaded_irq() and > the irq core will use irq_default_primary_handler() which is exactly > the same function :-) > > Regards > Stanislaw > > You are correct but in patch 19/27 (the one after this), this function is filled with actual code, so I don't know if it's worth changing this patch... Oded