On Thu, Feb 16, 2023 at 02:52:51PM +0200, Ville Syrjälä wrote: > On Thu, Feb 16, 2023 at 01:03:02PM +0100, Thomas Zimmermann wrote: > > Hi, > > > > thanks for taking a look at the patches. > > > > Am 16.02.23 um 12:33 schrieb Gerd Hoffmann: > > > On Wed, Feb 15, 2023 at 05:15:17PM +0100, Thomas Zimmermann wrote: > > >> Set the VGA bit for unblanking with macro constants instead of magic > > >> values. No functional changes. > > > > > > blank/unblank should work simliar to bochs (see commit 250e743915d4), > > > that is maybe a nice thing to add of you modernize the driver anyway. > > Yeah, it's the VGA PAS field. [1] But is it really called blanking? PAS > > controls palette access, but blanking is sounds more like DPMS. > > Why aren't people just using the normal way of flipping the > screen off bit in sequencer register 01? qemu vga emulation doesn't check that bit ... take care, Gerd
