On Sun, Feb 12, 2023 at 10:44:45PM +0200, Oded Gabbay wrote: > - rc = request_irq(irq, irq_handler, 0, gaudi2_irq_name(i), &hdev->user_interrupt[j]); > + rc = request_threaded_irq(irq, irq_handler, hl_irq_user_interrupt_thread_handler, > + IRQF_ONESHOT, gaudi2_irq_name(i), &hdev->user_interrupt[j]); > + Would be nice to change to devm_ and simplify exit paths. Up to you. Regards Stanislaw