Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/John-C-Harrison-Intel-com/drm-i915-Don-t-use-stolen-memory-for-ring-buffers-with-LLC/20230216-082552 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link: https://lore.kernel.org/r/20230216002248.1851966-3-John.C.Harrison%40Intel.com patch subject: [Intel-gfx] [PATCH v2 2/2] drm/i915: Don't use BAR mappings for ring buffers with LLC config: i386-randconfig-a011-20230213 (https://download.01.org/0day-ci/archive/20230216/202302161021.TjavhrpH-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/fa748ad303922e4138a246d4db247dfa96e45651 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review John-C-Harrison-Intel-com/drm-i915-Don-t-use-stolen-memory-for-ring-buffers-with-LLC/20230216-082552 git checkout fa748ad303922e4138a246d4db247dfa96e45651 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 olddefconfig make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202302161021.TjavhrpH-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): drivers/gpu/drm/i915/gt/intel_ring.c: In function 'intel_ring_unpin': >> drivers/gpu/drm/i915/gt/intel_ring.c:103:9: error: expected '}' before 'else' 103 | else | ^~~~ vim +103 drivers/gpu/drm/i915/gt/intel_ring.c 2871ea85c119e6f Chris Wilson 2019-10-24 92 2871ea85c119e6f Chris Wilson 2019-10-24 93 void intel_ring_unpin(struct intel_ring *ring) 2871ea85c119e6f Chris Wilson 2019-10-24 94 { 2871ea85c119e6f Chris Wilson 2019-10-24 95 struct i915_vma *vma = ring->vma; 2871ea85c119e6f Chris Wilson 2019-10-24 96 2871ea85c119e6f Chris Wilson 2019-10-24 97 if (!atomic_dec_and_test(&ring->pin_count)) 2871ea85c119e6f Chris Wilson 2019-10-24 98 return; 2871ea85c119e6f Chris Wilson 2019-10-24 99 2871ea85c119e6f Chris Wilson 2019-10-24 100 i915_vma_unset_ggtt_write(vma); fa748ad303922e4 Daniele Ceraolo Spurio 2023-02-15 101 if (i915_vma_is_map_and_fenceable(vma) && !HAS_LLC(vma->vm->i915)) { 2871ea85c119e6f Chris Wilson 2019-10-24 102 i915_vma_unpin_iomap(vma); 2871ea85c119e6f Chris Wilson 2019-10-24 @103 else 2871ea85c119e6f Chris Wilson 2019-10-24 104 i915_gem_object_unpin_map(vma->obj); 2871ea85c119e6f Chris Wilson 2019-10-24 105 2871ea85c119e6f Chris Wilson 2019-10-24 106 i915_vma_make_purgeable(vma); a266bf420060043 Chris Wilson 2019-11-18 107 i915_vma_unpin(vma); 2871ea85c119e6f Chris Wilson 2019-10-24 108 } 2871ea85c119e6f Chris Wilson 2019-10-24 109 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
