On Thu, Feb 09, 2023 at 10:15:33AM +0100, AngeloGioacchino Del Regno wrote: > Il 09/02/23 03:50, Chen-Yu Tsai ha scritto: > > On Wed, Feb 8, 2023 at 6:37 PM AngeloGioacchino Del Regno > > <angelogioacchino.delregno@xxxxxxxxxxxxx> wrote: > > > > > > The sram-supply is MediaTek-specific, it is and will ever be used > > > only for the mediatek,mt8183-mali compatible due to the addition of > > > the mediatek-regulator-coupler driver: change the binding to add > > > this supply when mediatek,mt8183-mali is present as a compatible > > > instead of disabling it when not present. > > > > > > This is done in preparation for adding new bindings for other > > > MediaTek SoCs, such as MT8192 and others. > > > > > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> > > > --- > > > Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 4 +--- > > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > > > index 78964c140b46..69212f3b1328 100644 > > > --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > > > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > > > @@ -57,8 +57,6 @@ properties: > > > > > > mali-supply: true > > > > > > - sram-supply: true > > > - > > > > Have you tried actually validating the device trees against this? > > Based on my previous tests this gives out errors. > > I did... and I didn't get any complaint... but perhaps something went wrong > on my side? > > I mean, I can retry just to be sure. You should need unevaluatedProperties instead of additionalProperties for this to work. The latter cannot 'see' into an if/then schema. But really we want the default top level to allow this and then disallow it in an if/then schema. Rob
