Hi Darrell, On 2/3/23 19:32, Darrell Kavanagh wrote: > Hi, > > This is another Lenovo with detachable keyboard and 1200x1920 screen > mounted sideways. > > The following has been tested with 6.2.0-rc6. > > Thanks, > Darrell Thank you for your patch. Note that instead of "Hi, ... Thanks, Darrell" there should be a message describing the what and why of the patch here, see e.g. : https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/gpu/drm/drm_panel_orientation_quirks.c?id=653f2d94fcda200b02bd79cea2e0307b26c1b747 I also notice that the diff output below has a bit weird file-paths, so this patch is clearly not the output of "git format-patch" + "git send-email" on a standard linux source tree git clone. The whole kernel patch workflow can be a bit daunting if you are just trying to submit a small quirk like this. So you can either try again if you want to, or I can fix all of this up for you if that is preferred. If you want me to fix this up for you, there is one thing which I still need from you, your patch is missing a Signed-off-by line in the commit-message. I can only accept patches with a Signed-off-by line in the commit-message like this: Signed-off-by: Your Real Name <email@your.domain> By adding this line you indicate that you are the author of the code and are submitting it under the existing license for the file which you are modifying (typically GPL-2.0) or that you have permission from the author to submit it under this license. See: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin If you want me to fix this up for you, please reply to this email with the proper Signed-off-by: ... line for me to add to the commit message. Regards, Hans > > index 3659f04..590bb7b 100644 > --- a/kernel/drm_panel_orientation > _quirks.c > +++ b/kernel/linux-6.2-rc6/drivers/gpu/drm/drm_panel_orientation_quirks.c > @@ -304,6 +304,12 @@ static const struct dmi_system_id orientation_data[] = { > DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad > D330-10IGM"), > }, > .driver_data = (void *)&lcd1200x1920_rightside_up, > + }, { /* Lenovo IdeaPad Duet 3 10IGL5 */ > + .matches = { > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "IdeaPad Duet 3 10IGL5"), > + }, > + .driver_data = (void *)&lcd1200x1920_rightside_up, > }, { /* Lenovo Ideapad D330-10IGL (HD) */ > .matches = { > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), >
