Re: [PATCH 1/4] accel/ivpu: Fix FW API data alignment issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/2/2023 2:21 AM, Stanislaw Gruszka wrote:
From: Andrzej Kacprowski <andrzej.kacprowski@xxxxxxxxxxxxxxx>

FW API structures have been updated to fix misaligned
structure members.

Also changed JSM message header format to account for
future improvements.

Added explicit check for minimum supported JSM API version.

Signed-off-by: Andrzej Kacprowski <andrzej.kacprowski@xxxxxxxxxxxxxxx>
Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@xxxxxxxxxxxxxxx>


  /*
   * Job format.
@@ -119,7 +119,7 @@ struct vpu_job_queue_entry {
  	u64 root_page_table_update_counter; /**< Page tables update events counter */
  	u64 preemption_buffer_address; /**< Address of the preemption buffer to use for this job */
  	u64 preemption_buffer_size; /**< Size of the preemption buffer to use for this job */
-	u8 reserved[VPU_JOB_RESERVED_BYTES];
+	u8 reserved_0[VPU_JOB_RESERVED_BYTES];

This seems spurious, just adding "_0" to the name. Seems like the majority of the changes are like this (although you have a _1 at the very end). Are you anticipating adding additional reserved fields in the near future?




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux