On Sun, Jan 29, 2023 at 04:17:40PM +0100, Samuel Thibault wrote: > blit_x and blit_y are u32, so fbcon currently cannot support fonts > larger than 32x32. > > The 32x32 case also needs shifting an unsigned int, to properly set bit > 31, otherwise we get "UBSAN: shift-out-of-bounds in fbcon_set_font", > as reported on: > > http://lore.kernel.org/all/IA1PR07MB98308653E259A6F2CE94A4AFABCE9@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx > Kernel Branch: 6.2.0-rc5-next-20230124 > Kernel config: https://drive.google.com/file/d/1F-LszDAizEEH0ZX0HcSR06v5q8FPl2Uv/view?usp=sharing > Reproducer: https://drive.google.com/file/d/1mP1jcLBY7vWCNM60OMf-ogw-urQRjNrm/view?usp=sharing > > Reported-by: Sanan Hasanov <sanan.hasanov@xxxxxxxxxxxxxxx> > Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx> > Fixes: 2d2699d98492 ("fbcon: font setting should check limitation of driver") > Cc: stable@xxxxxxxxxxxxxxx Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
