On 2023-01-23 10:24:29, Kuogee Hsieh wrote: <snip> > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > index d612419..70a74ed 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c <snip> > @@ -892,6 +894,10 @@ static void dpu_kms_mdp_snapshot(struct msm_disp_state *disp_state, struct msm_k > > pm_runtime_get_sync(&dpu_kms->pdev->dev); > > + for (i = 0; i < cat->dsc_count; i++) > + msm_disp_snapshot_add_block(disp_state, cat->dsc[i].len, > + dpu_kms->mmio + cat->dsc[i].base, "dsc_%d", i); > + Note that we've landed snapshotting of the DSC block in [1] because we need it now, and - as discussed elsewhere - is perfect material to be submitted in a standalone, appropriately described/titled patch (fine to be part of a series, as long as that patch comprises this single diff). [1]: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=a7efe60e36b9c0e966d7f82ac90a89b591d984e9 Keep in mind that it was added at the bottom of dpu_kms_mdp_snapshot() instead of the top, so git might not clean it up or mark it as conflict during a rebase; don't forget to drop it from v2 :) > /* dump CTL sub-blocks HW regs info */ > for (i = 0; i < cat->ctl_count; i++) > msm_disp_snapshot_add_block(disp_state, cat->ctl[i].len, <snip> - Marijn
