Re: [PATCH 2/2] accel/ivpu: avoid duplciate assignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



duplciate -> duplicate

On 1/26/2023 9:37 AM, Arnd Bergmann wrote:
From: Arnd Bergmann <arnd@xxxxxxxx>

With extra warnings enabled, gcc warns about two assignments
of the same .mmap callback:

In file included from drivers/accel/ivpu/ivpu_drv.c:10:
include/drm/drm_accel.h:31:27: error: initialized field overwritten [-Werror=override-init]
    31 |         .mmap           = drm_gem_mmap
       |                           ^~~~~~~~~~~~
drivers/accel/ivpu/ivpu_drv.c:360:9: note: in expansion of macro 'DRM_ACCEL_FOPS'
   360 |         DRM_ACCEL_FOPS,
       |         ^~~~~~~~~~~~~~

Remove the unused local assignment.

Fixes: 20709aa9435b ("accel: Add .mmap to DRM_ACCEL_FOPS")
Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Yep, two things in flight at the same time. Thanks for getting to the cleanup before I did.

Reviewed-by: Jeffrey Hugo <quic_jhugo@xxxxxxxxxxx>





[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux