On 25/01/2023 22:09, Jonathan Cormier wrote:
> Add a i2c example with HDMI connector
Why? It's the same - but more on this below.
>
> Signed-off-by: Jonathan Cormier <jcormier@xxxxxxxxxxxxxxxx>
You need to test the bindings before sending and fix the errors.
> ---
> .../bindings/display/bridge/ti,tfp410.yaml | 42 ++++++++++++++++++++++
> 1 file changed, 42 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml b/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml
> index 4c5dd8ec2951..456214f14b47 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml
> @@ -116,4 +116,46 @@ examples:
> };
> };
>
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + hdmi_encoder: tfp410@38 {
Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "ti,tfp410";
> + reg = <0x38>;
> +
> + ports {
> + address-cells = <1>;
> + size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + tfp410_in: endpoint {
> + remote-endpoint = <&dpi1_out>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> + tfp410_out: endpoint {
> + remote-endpoint = <&hdmi_connector_in>;
> + };
That's the same example as existing one, so it looks useless. I don't
see benefits of this example.
> + };
> + };
> + };
> + };
> +
> + hdmi: hdmi_connector {
Drop. Incorrect name and not really related.
> + compatible = "hdmi-connector";
> + label = "hdmi";
> + type = "a";
> + ddc-i2c-bus = <&i2c1>;
> + port {
> + hdmi_connector_in: endpoint {
> + remote-endpoint = <&tfp410_out>;
> + };
> + };
> + };
> +
> ...
>
Best regards,
Krzysztof
