Hello Thomas,
On 1/24/23 14:40, Thomas Zimmermann wrote:
> Test for connectors in the client code and remove a similar test
> from the generic fbdev emulation. Do nothing if the test fails.
> Not having connectors indicates a driver bug.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> ---
Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
but I've a question below.
> drivers/gpu/drm/drm_client.c | 5 +++++
> drivers/gpu/drm/drm_fbdev_generic.c | 5 -----
> 2 files changed, 5 insertions(+), 5 deletions(-)
[...]
> --- a/drivers/gpu/drm/drm_fbdev_generic.c
> +++ b/drivers/gpu/drm/drm_fbdev_generic.c
> @@ -389,11 +389,6 @@ static int drm_fbdev_client_hotplug(struct drm_client_dev *client)
> if (dev->fb_helper)
> return drm_fb_helper_hotplug_event(dev->fb_helper);
>
> - if (!dev->mode_config.num_connector) {
> - drm_dbg_kms(dev, "No connectors found, will not create framebuffer!\n");
> - return 0;
> - }
> -
What about the following code snippet:
if (!drm_drv_uses_atomic_modeset(dev))
drm_helper_disable_unused_functions(dev);
that seems to be something that should be in the core client dev hotplug
as well, since it isn't specific to the fbdev emulation client ?
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
