Thanks Daniele - agreed on all counts - will fix accordingly - already done and tested internally - will re-rev shortly. ..alan On Wed, 2023-01-18 at 17:50 -0800, Ceraolo Spurio, Daniele wrote: > > > On 1/11/2023 1:42 PM, Alan Previn wrote: > > Add MTL's function for ARB session creation using PXP firmware > > version 4.3 ABI structure format. > > > > Before checking the return status, look at the GSC-CS-Mem-Header's > > pending-bit which means the GSC firmware is busy and we should > > resubmit. > > > > Signed-off-by: Alan Previn <alan.previn.teres.alexis@xxxxxxxxx> > > --- > > .../drm/i915/pxp/intel_pxp_cmd_interface_43.h | 21 +++++++ > > drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c | 56 ++++++++++++++++++- > > 2 files changed, 74 insertions(+), 3 deletions(-) alan:snip..