On Fri, Jan 20, 2023 at 10:06:48AM +0100, Guido Günther wrote:
> Hi,
> On Thu, Jan 19, 2023 at 05:04:15PM -0600, Chris Morgan wrote:
> > From: Chris Morgan <macromorgan@xxxxxxxxxxx>
> >
> > The Anbernic RG353V-V2 is a 5 inch panel used in a new revision of the
> > Anbernic RG353V handheld gaming device. Add support for it.
> >
> > Unfortunately it appears this controller is not able to support 120hz
> > or 100hz mode like the first revision panel.
> >
> > Signed-off-by: Chris Morgan <macromorgan@xxxxxxxxxxx>
> > ---
> > drivers/gpu/drm/panel/panel-sitronix-st7703.c | 102 +++++++++++++++++-
> > 1 file changed, 99 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c b/drivers/gpu/drm/panel/panel-sitronix-st7703.c
> > index 86a472b01360..2ed0cdfa86de 100644
> > --- a/drivers/gpu/drm/panel/panel-sitronix-st7703.c
> > +++ b/drivers/gpu/drm/panel/panel-sitronix-st7703.c
> > @@ -28,6 +28,7 @@
> > /* Manufacturer specific Commands send via DSI */
> > #define ST7703_CMD_ALL_PIXEL_OFF 0x22
> > #define ST7703_CMD_ALL_PIXEL_ON 0x23
> > +#define ST7703_CMD_SETAPID 0xB1
> > #define ST7703_CMD_SETDISP 0xB2
> > #define ST7703_CMD_SETRGBIF 0xB3
> > #define ST7703_CMD_SETCYC 0xB4
> > @@ -41,12 +42,15 @@
> > #define ST7703_CMD_UNKNOWN_BF 0xBF
> > #define ST7703_CMD_SETSCR 0xC0
> > #define ST7703_CMD_SETPOWER 0xC1
> > +#define ST7703_CMD_SETECO 0xC6
> > +#define ST7703_CMD_SETIO 0xC7
> > +#define ST7703_CMD_SETCABC 0xC8
> > #define ST7703_CMD_SETPANEL 0xCC
> > -#define ST7703_CMD_UNKNOWN_C6 0xC6
> > #define ST7703_CMD_SETGAMMA 0xE0
> > #define ST7703_CMD_SETEQ 0xE3
> > #define ST7703_CMD_SETGIP1 0xE9
> > #define ST7703_CMD_SETGIP2 0xEA
> > +#define ST7703_CMD_UNKNOWN_EF 0xEF
> >
> > struct st7703 {
> > struct device *dev;
> > @@ -266,8 +270,7 @@ static int xbd599_init_sequence(struct st7703 *ctx)
> > * ESD_DET_TIME_SEL = 0 frames
> > */);
> >
> > - /* Undocumented command. */
> > - dsi_dcs_write_seq(dsi, ST7703_CMD_UNKNOWN_C6, 0x01, 0x00, 0xFF, 0xFF, 0x00);
> > + dsi_dcs_write_seq(dsi, ST7703_CMD_SETECO, 0x01, 0x00, 0xFF, 0xFF, 0x00);
>
> Thanks for catching this! Would make sense to split that into a separate
> commit. With that fixed
I can, if you would prefer. I just thought it was trivial so I wrapped
it up in a single commit. I had a newer revision of the ST7703
datasheet on hand that had that command documented, but unfortunately
not BF or a new command I added EF. If a new commit is preferred I'll
resubmit early next week.
Thank you.
>
> Reviewed-by: Guido Günther <agx@xxxxxxxxxxx>
>
> -- Guido
>
> >
> > dsi_dcs_write_seq(dsi, ST7703_CMD_SETPOWER,
> > 0x74, /* VBTHS, VBTLS: VGH = 17V, VBL = -11V */
> > @@ -355,6 +358,98 @@ static const struct st7703_panel_desc xbd599_desc = {
> > .init_sequence = xbd599_init_sequence,
> > };
> >
> > +static int rg353v2_init_sequence(struct st7703 *ctx)
> > +{
> > + struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
> > +
> > + /*
> > + * Init sequence was supplied by the panel vendor.
> > + */
> > +
> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETEXTC, 0xf1, 0x12, 0x83);
> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETAPID, 0x00, 0x00, 0x00,
> > + 0xda, 0x80);
> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETDISP, 0x00, 0x13, 0x70);
> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETRGBIF, 0x10, 0x10, 0x28,
> > + 0x28, 0x03, 0xff, 0x00, 0x00, 0x00, 0x00);
> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETCYC, 0x80);
> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETBGP, 0x0a, 0x0a);
> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETVCOM, 0x92, 0x92);
> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETPOWER_EXT, 0x25, 0x22,
> > + 0xf0, 0x63);
> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETMIPI, 0x33, 0x81, 0x05,
> > + 0xf9, 0x0e, 0x0e, 0x20, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0x00, 0x00, 0x44, 0x25, 0x00, 0x90, 0x0a,
> > + 0x00, 0x00, 0x01, 0x4f, 0x01, 0x00, 0x00, 0x37);
> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETVDC, 0x47);
> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_UNKNOWN_BF, 0x02, 0x11, 0x00);
> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETSCR, 0x73, 0x73, 0x50, 0x50,
> > + 0x00, 0x00, 0x12, 0x50, 0x00);
> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETPOWER, 0x53, 0xc0, 0x32,
> > + 0x32, 0x77, 0xe1, 0xdd, 0xdd, 0x77, 0x77, 0x33,
> > + 0x33);
> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETECO, 0x82, 0x00, 0xbf, 0xff,
> > + 0x00, 0xff);
> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETIO, 0xb8, 0x00, 0x0a, 0x00,
> > + 0x00, 0x00);
> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETCABC, 0x10, 0x40, 0x1e,
> > + 0x02);
> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETPANEL, 0x0b);
> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETGAMMA, 0x00, 0x07, 0x0d,
> > + 0x37, 0x35, 0x3f, 0x41, 0x44, 0x06, 0x0c, 0x0d,
> > + 0x0f, 0x11, 0x10, 0x12, 0x14, 0x1a, 0x00, 0x07,
> > + 0x0d, 0x37, 0x35, 0x3f, 0x41, 0x44, 0x06, 0x0c,
> > + 0x0d, 0x0f, 0x11, 0x10, 0x12, 0x14, 0x1a);
> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETEQ, 0x07, 0x07, 0x0b, 0x0b,
> > + 0x0b, 0x0b, 0x00, 0x00, 0x00, 0x00, 0xff, 0x00,
> > + 0xc0, 0x10);
> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETGIP1, 0xc8, 0x10, 0x02, 0x00,
> > + 0x00, 0xb0, 0xb1, 0x11, 0x31, 0x23, 0x28, 0x80,
> > + 0xb0, 0xb1, 0x27, 0x08, 0x00, 0x04, 0x02, 0x00,
> > + 0x00, 0x00, 0x00, 0x04, 0x02, 0x00, 0x00, 0x00,
> > + 0x88, 0x88, 0xba, 0x60, 0x24, 0x08, 0x88, 0x88,
> > + 0x88, 0x88, 0x88, 0x88, 0x88, 0xba, 0x71, 0x35,
> > + 0x18, 0x88, 0x88, 0x88, 0x88, 0x88, 0x00, 0x00,
> > + 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0x00, 0x00);
> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETGIP2, 0x97, 0x0a, 0x82, 0x02,
> > + 0x03, 0x07, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x81, 0x88, 0xba, 0x17, 0x53, 0x88, 0x88, 0x88,
> > + 0x88, 0x88, 0x88, 0x80, 0x88, 0xba, 0x06, 0x42,
> > + 0x88, 0x88, 0x88, 0x88, 0x88, 0x88, 0x23, 0x00,
> > + 0x00, 0x02, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> > + 0x00);
> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_UNKNOWN_EF, 0xff, 0xff, 0x01);
> > +
> > + return 0;
> > +}
> > +
> > +static const struct drm_display_mode rg353v2_mode = {
> > + .hdisplay = 640,
> > + .hsync_start = 640 + 40,
> > + .hsync_end = 640 + 40 + 2,
> > + .htotal = 640 + 40 + 2 + 80,
> > + .vdisplay = 480,
> > + .vsync_start = 480 + 18,
> > + .vsync_end = 480 + 18 + 2,
> > + .vtotal = 480 + 18 + 2 + 28,
> > + .clock = 24150,
> > + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> > + .width_mm = 70,
> > + .height_mm = 57,
> > +};
> > +
> > +static const struct st7703_panel_desc rg353v2_desc = {
> > + .mode = &rg353v2_mode,
> > + .lanes = 4,
> > + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
> > + MIPI_DSI_MODE_NO_EOT_PACKET | MIPI_DSI_MODE_LPM,
> > + .format = MIPI_DSI_FMT_RGB888,
> > + .init_sequence = rg353v2_init_sequence,
> > +};
> > +
> > static int st7703_enable(struct drm_panel *panel)
> > {
> > struct st7703 *ctx = panel_to_st7703(panel);
> > @@ -615,6 +710,7 @@ static void st7703_remove(struct mipi_dsi_device *dsi)
> > }
> >
> > static const struct of_device_id st7703_of_match[] = {
> > + { .compatible = "anbernic,rg353v-panel-v2", .data = &rg353v2_desc },
> > { .compatible = "rocktech,jh057n00900", .data = &jh057n00900_panel_desc },
> > { .compatible = "xingbangda,xbd599", .data = &xbd599_desc },
> > { /* sentinel */ }
> > --
> > 2.34.1
> >
