Re: [PATCH 2/6] drm: rcar-du: lvds: Add reset control

Tomi Valkeinen <tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx> · Thu, 19 Jan 2023 10:36:55 +0200

On 17/01/2023 18:04, Geert Uytterhoeven wrote:
Hi Tomi,

On Tue, Jan 17, 2023 at 2:54 PM Tomi Valkeinen
<tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx> wrote:
From: Koji Matsuoka <koji.matsuoka.xm@xxxxxxxxxxx>

Reset LVDS using the reset control as CPG reset/release is required in
H/W manual sequence.

Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@xxxxxxxxxxx>
Signed-off-by: LUU HOAI <hoai.luu.ub@xxxxxxxxxxx>
[tomi.valkeinen: Rewrite the patch description]
Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx>

Thanks for your patch!

--- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
+++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c

@@ -844,6 +853,12 @@ static int rcar_lvds_probe(struct platform_device *pdev)
         if (ret < 0)
                 return ret;

+       lvds->rstc = devm_reset_control_get(&pdev->dev, NULL);

devm_reset_control_get_exclusive()

Ok.

+       if (IS_ERR(lvds->rstc)) {
+               dev_err(&pdev->dev, "failed to get cpg reset\n");
+               return PTR_ERR(lvds->rstc);

return dev_err_probe(...);

Right.

Thanks!

 Tomi







