On 04/01/2023 13:03, Boris Brezillon wrote: > Hello, > > Here's an attempt at exposing some memory usage stats through fdinfo, > which recently proved useful in debugging a memory leak. Not entirely > sure the name I chose are accurate, so feel free to propose > alternatives, and let me know if you see any other mem-related stuff > that would be interesting to expose. Sorry it's taken me a while to look at this - I'm still working through the holiday backlog. The names look reasonable to me, and I gave this a quick spin and it seemed to work (the numbers reported looks reasonable). As Daniel suggested it would be good if some of the boiler plate fdinfo code could be moved to generic code (although to be fair there's not much here). Of course what we're missing is the 'engine' usage information for gputop - it's been on my todo list of a while, but I'm more than happy for you to do it for me ;) It's somewhat more tricky because of the whole 'queuing' on slots mechanism that Mali has. But we obviously shouldn't block this memory implementation on that, it can be added afterwards. Anyway, for the series as it is: Reviewed-by: Steven Price <steven.price@xxxxxxx> Thanks, Steve > Regards, > > Boris > > Boris Brezillon (4): > drm/panfrost: Provide a dummy show_fdinfo() implementation > drm/panfrost: Track BO resident size > drm/panfrost: Add a helper to retrieve MMU context stats > drm/panfrost: Expose some memory related stats through fdinfo > > drivers/gpu/drm/panfrost/panfrost_drv.c | 24 ++++++++++++++++- > drivers/gpu/drm/panfrost/panfrost_gem.h | 7 +++++ > .../gpu/drm/panfrost/panfrost_gem_shrinker.c | 1 + > drivers/gpu/drm/panfrost/panfrost_mmu.c | 27 +++++++++++++++++++ > drivers/gpu/drm/panfrost/panfrost_mmu.h | 10 +++++++ > 5 files changed, 68 insertions(+), 1 deletion(-) >
