Re: [PATCH] drm/vc4: bo: Fix unused variable warning

[Maíra Canal <mcanal@xxxxxxxxxx>]

On 1/13/23 12:46, Maxime Ripard wrote:
> Commit 07a2975c65f2 ("drm/vc4: bo: Fix drmm_mutex_init memory hog")
> removed the only user of the ret variable, but didn't remove the

s/user/use

> variable itself leading to a unused variable warning.
>
> Remove that variable.
>
> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Fixes: 07a2975c65f2 ("drm/vc4: bo: Fix drmm_mutex_init memory hog")
> Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx>

With that small nit:

Reviewed-by: Maíra Canal <mcanal@xxxxxxxxxx>

Best Regards,
- Maíra Canal

> ---
>   drivers/gpu/drm/vc4/vc4_bo.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c
> index 29ce2fa72cc4..c5947ed8cc81 100644
> --- a/drivers/gpu/drm/vc4/vc4_bo.c
> +++ b/drivers/gpu/drm/vc4/vc4_bo.c
> @@ -395,7 +395,6 @@ struct drm_gem_object *vc4_create_object(struct drm_device *dev, size_t size)
>   {
>   	struct vc4_dev *vc4 = to_vc4_dev(dev);
>   	struct vc4_bo *bo;
> -	int ret;
>   
>   	if (WARN_ON_ONCE(vc4->is_vc5))
>   		return ERR_PTR(-ENODEV);