Hi Ville, On Wed, Jan 11, 2023 at 06:08:42PM +0200, Ville Syrjälä wrote: > On Wed, Jan 11, 2023 at 02:01:58PM +0100, Thomas Zimmermann wrote: > > Include <linux/of.h> in source files that need it. Some of DRM's > > source code gets OF header via drm_crtc_helper.h and <linux/fb.h>, > > which can leed to unnecessary recompilation. > > > > In drm_modes.c, add a comment on the reason for still including > > <linux/fb.h>. The header file is required to get KHZ2PICOS(). The > > macro is part of the UAPI headers, so it cannot be moved to a less > > prominent location. > > I never liked that KHZ2PICOS() thing in there. Maybe we should > just nuke it and see if anyone notices? https://github.com/search?q=KHZ2PICOS&type=code tells me that it will be noticed. So it is part of the UAPI Sam
