On Wed, Jan 11, 2023 at 10:21 PM Pin-yen Lin <treapking@xxxxxxxxxxxx> wrote: > > > This series introduces bindings for anx7625/it6505 to register Type-C > mode-switch in their output endpoints, and use data-lanes property to > describe the pin connections. > > The first two patch modifies fwnode_graph_devcon_matches and > cros_typec_init_ports to enable the registration of the switches. > > Patch 4~6 introduce the bindings for anx7625 and the corresponding driver > modifications. > > Patch 7~9 add similar bindings and driver changes for it6505. > > v9: https://lore.kernel.org/all/20230109084101.265664-1-treapking@xxxxxxxxxxxx/ > v8: https://lore.kernel.org/all/20230107102231.23682-1-treapking@xxxxxxxxxxxx/ > v7: https://lore.kernel.org/all/20230105132457.4125372-1-treapking@xxxxxxxxxxxx/ > v6: https://lore.kernel.org/all/20221124102056.393220-1-treapking@xxxxxxxxxxxx/ > v5: https://lore.kernel.org/linux-usb/20220622173605.1168416-1-pmalani@xxxxxxxxxxxx/ > > Changes in v10: > - Collected Reviewed-by and Tested-by tags > - Replaced "void *" with "typec_mux_set_fn_t" for mux_set callbacks > - Print out the node name when errors on parsing DT > - Use dev_dbg instead of dev_warn when no Type-C switch nodes available > - Made the return path of drm_dp_register_mode_switch clearer > - Added a TODO for implementing orientation switch for anx7625 > - Updated the commit message for the absence of orientation switch > - Fixed typo in the commit message > > Changes in v9: > - Collected Reviewed-by tag > - Fixed subject prefix again > - Changed the naming of the example node for it6505 > > Changes in v8: > - Fixed the build issue when CONFIG_TYPEC=m > - Fixed some style issues > - Fixed the subject prefixes for the bindings patch > - Fixed the bindings for data-lanes properties > > Changes in v7: > - Fix the long comment lines > - Extracted the common codes to a helper function > - Fixed style issues in anx7625 driver > - Removed DT property validation in anx7625 driver. > - Fixed style issues in it6505 driver > - Removed the redundant sleep in it6505 driver > - Removed DT property validation in it6505 driver > - Rebased to drm-misc-next > - Fixed indentations in bindings patches > - Added a new patch to fix indentations in Kconfig 4 versions in a week! Please slow down your pace. When you send a new version, you move to the end of my review queue. IIRC, these 2 chips are a bit different in what the mode switch or muxing looks like. One had a built-in mux and the other doesn't? Do I have to go research this again? No, you need to explain all this in this series. Rob
