Re: [PATCH 3/5] drm/amdgpu: Do not include <linux/fb.h>

[Christian König <ckoenig.leichtzumerken@xxxxxxxxx>]

Am 09.01.23 um 11:12 schrieb Thomas Zimmermann:
> Remove unnecessary include statements for <linux/fb.h>. No functional
> changes.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>

Acked-by: Christian König <christian.koenig@xxxxxxx>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c                         | 1 -
>   drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c             | 1 -
>   drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c           | 1 -
>   drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_processpptables.c | 1 -
>   drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_hwmgr.c           | 1 -
>   drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c | 1 -
>   drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.c           | 1 -
>   drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_processpptables.c | 1 -
>   drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c             | 1 -
>   9 files changed, 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 1353ffd08988..ebc6e6cbe2ab 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -39,7 +39,6 @@
>   #include <linux/mmu_notifier.h>
>   #include <linux/suspend.h>
>   #include <linux/cc_platform.h>
> -#include <linux/fb.h>
>   #include <linux/dynamic_debug.h>
>   
>   #include "amdgpu.h"
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c
> index 7ef7e81525a3..d6edd83f67c6 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c
> @@ -22,7 +22,6 @@
>    */
>   #include "pp_debug.h"
>   #include <linux/delay.h>
> -#include <linux/fb.h>
>   #include <linux/module.h>
>   #include <linux/pci.h>
>   #include <linux/slab.h>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c
> index c8c9fb827bda..733cac4600ff 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c
> @@ -22,7 +22,6 @@
>    */
>   
>   #include <linux/delay.h>
> -#include <linux/fb.h>
>   #include <linux/module.h>
>   #include <linux/pci.h>
>   #include <linux/slab.h>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_processpptables.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_processpptables.c
> index 95b988823f50..bb90d8abf79b 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_processpptables.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_processpptables.c
> @@ -23,7 +23,6 @@
>   #include <linux/module.h>
>   #include <linux/pci.h>
>   #include <linux/slab.h>
> -#include <linux/fb.h>
>   
>   #include "vega10_processpptables.h"
>   #include "ppatomfwctrl.h"
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_hwmgr.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_hwmgr.c
> index a2f4d6773d45..c73693dc4c09 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_hwmgr.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_hwmgr.c
> @@ -22,7 +22,6 @@
>    */
>   
>   #include <linux/delay.h>
> -#include <linux/fb.h>
>   #include <linux/module.h>
>   #include <linux/slab.h>
>   
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c
> index bd54fbd393b9..89148f73b514 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c
> @@ -22,7 +22,6 @@
>    */
>   #include <linux/module.h>
>   #include <linux/slab.h>
> -#include <linux/fb.h>
>   
>   #include "vega12/smu9_driver_if.h"
>   #include "vega12_processpptables.h"
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.c
> index b30684c84e20..33f3d9792181 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.c
> @@ -22,7 +22,6 @@
>    */
>   
>   #include <linux/delay.h>
> -#include <linux/fb.h>
>   #include <linux/module.h>
>   #include <linux/slab.h>
>   
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_processpptables.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_processpptables.c
> index 1f9082539457..79c817752a33 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_processpptables.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_processpptables.c
> @@ -22,7 +22,6 @@
>    */
>   #include <linux/module.h>
>   #include <linux/slab.h>
> -#include <linux/fb.h>
>   
>   #include "smu11_driver_if.h"
>   #include "vega20_processpptables.h"
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c b/drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c
> index 5ca3c422f7d4..5c3f42d97f69 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c
> @@ -22,7 +22,6 @@
>    */
>   #include <linux/module.h>
>   #include <linux/slab.h>
> -#include <linux/fb.h>
>   #include "linux/delay.h"
>   #include <linux/types.h>
>   #include <linux/pci.h>