On Mon, 9 Jan 2023 at 10:21, Marijn Suijten
<marijn.suijten@xxxxxxxxxxxxxx> wrote:
>
> On 2023-01-09 01:31:57, Dmitry Baryshkov wrote:
> > On 22/12/2022 01:19, Marijn Suijten wrote:
> > > Downstream calls this num_enc yet the DSC patches introduced a new
> > > num_dsc struct member, leaving num_enc effectively unused.
> > >
> > > Fixes: 7e9cc175b159 ("drm/msm/disp/dpu1: Add support for DSC in topology")
> > > Signed-off-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
> > > ---
> > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 9 ++++-----
> > > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 4 ++--
> > > drivers/gpu/drm/msm/msm_drv.h | 2 --
> > > 3 files changed, 6 insertions(+), 9 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> > > index 9c6817b5a194..a158cd502d38 100644
> > > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> > > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> > > @@ -579,19 +579,18 @@ static struct msm_display_topology dpu_encoder_get_topology(
> > > topology.num_dspp = topology.num_lm;
> > > }
> > >
> > > - topology.num_enc = 0;
> > > topology.num_intf = intf_count;
> > >
> > > if (dpu_enc->dsc) {
> > > - /* In case of Display Stream Compression (DSC), we would use
> > > - * 2 encoders, 2 layer mixers and 1 interface
> > > + /*
> > > + * In case of Display Stream Compression (DSC), we would use
> > > + * 2 DSC encoders, 2 layer mixers and 1 interface
> > > * this is power optimal and can drive up to (including) 4k
> > > * screens
> > > */
> > > - topology.num_enc = 2;
> > > topology.num_dsc = 2;
> > > - topology.num_intf = 1;
> > > topology.num_lm = 2;
> > > + topology.num_intf = 1;
> >
> > Unless there is a reason, please move num_intf assignment back while
> > preparing v3.
>
> The assignment was reordered to match the order described in the comment
> right above, such that this reads more naturally. Not sure if it's
> worth sending that as a separate fix, or drop it entirely.
I see. Sounds logical then. Let's keep it as is.
>
> > With that fixed:
> >
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
>
> <snip>
--
With best wishes
Dmitry
