On 04/01/2023 11:05, Neil Armstrong wrote:
On 04/01/2023 08:29, Tomi Valkeinen wrote:
On 28/12/2022 23:58, Dmitry Baryshkov wrote:
On 02/11/2022 20:06, Dmitry Baryshkov wrote:
From all the drivers using drm_bridge_connector only iMX/dcss and OMAP
DRM driver do a proper work of calling
drm_bridge_connector_en/disable_hpd() in right places. Rather than
teaching each and every driver how to properly handle
drm_bridge_connector's HPD, make that automatic.
Add two additional drm_connector helper funcs: enable_hpd() and
disable_hpd(). Make drm_kms_helper_poll_* functions call them (as this
is the time where the drm_bridge_connector's functions are called by
the
drivers too).
Since we are at the beginning of the development window, gracious
ping for this patchset.
It would be nice to finally handle the bridge_connector's hpd
properly. Calling drm_bridge_connector_enable_hpd() from
drm_bridge_connector_init() is not a proper way to do this. It
results in calling bridge->funcs->hpd_enable() before the rest of the
pipeline was set up properly.
For the series:
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>
I've been using this series in my local branch for quite a while to
fix the HPD issues. Works for me.
Thanks!
I still think the "fix" aspect should be highlighted more here, as the
current upstream triggers a WARN for "Hot plug detection already
enabled" (at least) on OMAP.
LGTM then !
Tomi, Dmitry, I can push the whole serie via drm-misc-next or -fixes
then, as you wish.
I'm fine either way. We have been living with the warning for some time,
so I don't think there is any urgency to get rid of it immediately.
--
With best wishes
Dmitry
