Hi Javier. On Wed, Dec 28, 2022 at 02:47:43AM +0100, Javier Martinez Canillas wrote: > Hello, > > This series contains cleanups for DRM panel drivers that define their own > DSI write macros instead of using what's already in <drm/drm_mipi_dsi.h>. > > The changes are quite trivial but I've only tested this with allmodconfig > and `make M=drivers/gpu/drm/panel/` so please review and testing would be > highly appreciated. Nice cleanup - I like it. In most of the patches there is some trivial indent that should be fixed, I think I noted it everywhere. Sorry - but no testing. The last patch is buggy - see the comment. I suggest to land patch 1 now (with the fix), this makes it easier for others to test on top of drm-misc-next. Sam > > Best regards, > Javier > > > Javier Martinez Canillas (14): > drm/mipi-dsi: Add a mipi_dsi_dcs_write_seq() macro > drm/panel-asus-z00t-tm5p5-n35596: Drop custom DSI write macros > drm/panel-sitronix-st7703: Drop custom DSI write macros > drm/panel-leadtek-ltk050h3146w: Drop custom DSI write macro > drm/panel-elida-kd35t133: Drop custom DSI write macro > drm/panel-boe-bf060y8m-aj0: Drop custom DSI write macro > drm/panel-novatek-nt35950: Drop custom DSI write macro > drm/panel-jdi-fhd-r63452: Drop custom DSI write macros > drm/panel-samsung-s6e88a0-ams452ef01: Drop custom DSI write macro > drm/panel-samsung-sofef00: Drop custom DSI write macro > drm/panel-sharp-ls060t1sx01: Drop custom DSI write macro > drm/panel-mantix-mlaf057we51: Drop custom DSI write macro > drm/panel-sony-tulip-truly-nt35521: Drop custom DSI write macro > drm/panel-xinpeng-xpp055c272: Drop custom DSI write macro > > .../drm/panel/panel-asus-z00t-tm5p5-n35596.c | 96 ++--- > .../gpu/drm/panel/panel-boe-bf060y8m-aj0.c | 28 +- > drivers/gpu/drm/panel/panel-elida-kd35t133.c | 34 +- > drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c | 50 +-- > .../drm/panel/panel-leadtek-ltk050h3146w.c | 64 ++-- > .../gpu/drm/panel/panel-mantix-mlaf057we51.c | 24 +- > drivers/gpu/drm/panel/panel-novatek-nt35950.c | 14 +- > .../panel/panel-samsung-s6e88a0-ams452ef01.c | 24 +- > drivers/gpu/drm/panel/panel-samsung-sofef00.c | 24 +- > .../gpu/drm/panel/panel-sharp-ls060t1sx01.c | 19 +- > drivers/gpu/drm/panel/panel-sitronix-st7703.c | 83 ++--- > .../panel/panel-sony-tulip-truly-nt35521.c | 348 +++++++++--------- > .../gpu/drm/panel/panel-xinpeng-xpp055c272.c | 44 +-- > include/drm/drm_mipi_dsi.h | 16 + > 14 files changed, 374 insertions(+), 494 deletions(-) > > -- > 2.38.1
