On Tue, Dec 27, 2022 at 3:46 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Tue, Dec 27, 2022 at 02:04:14PM +0200, Oded Gabbay wrote: > > On Tue, Dec 27, 2022 at 9:26 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > > > > On Mon, Dec 26, 2022 at 11:32:26PM +0200, Oded Gabbay wrote: > > > > Move the habanalabs.h uapi file from include/uapi/misc to > > > > include/uapi/drm, and rename it to habanalabs_accel.h. > > > > > > > > This is required before moving the actual driver to the accel > > > > subsystem. > > > > > > What requires this? Isn't this going to break userspace code? > > Yes, most definitely it will break userspace code. Moreover, the > > patches I'll send in 1-2 weeks to change the device char files will > > also break it. > > Having said that, I'm not worried because I don't believe anyone is > > working with the upstream version because there is no NIC support > > (yet). > > Ok, if you are sure that no one will complain about broken builds, > that's fine to move, but be aware that if they do complain, you'll have > to back these changes out. Of course, I completely understand that. Thanks, Oded > > thanks, > > greg k-h
