Hello Sam, On 12/23/22 10:17, Sam Ravnborg wrote: > Hi Javier. > > On Thu, Dec 22, 2022 at 11:38:27PM +0100, Javier Martinez Canillas wrote: >> From: Kamil Trzciński <ayufan@xxxxxxxxx> >> >> The driver is for panels based on the Himax HX8394 controller, such as the >> HannStar HSD060BHW4 720x1440 TFT LCD panel that uses a MIPI-DSI interface. > > A few comments/nitpicks in the following. > I have been away for a while, and paged out most of my panel knowledge, > so read it all with that in mind. > Thanks a lot for your feedback! I agree with your comments and will address those in the next iteration. > In general - very nicely written driver. > > Sam > -- Best regards, Javier Martinez Canillas Core Platforms Red Hat