On 22/12/2022 17:22, Kuogee Hsieh wrote: > > On 12/22/2022 2:47 AM, Krzysztof Kozlowski wrote: >> On 16/12/2022 20:11, Kuogee Hsieh wrote: >>> Move data-lanes property from mdss_dp node to dp_out endpoint. Also >>> add link-frequencies property into dp_out endpoint as well. The last >>> frequency specified at link-frequencies will be the max link rate >>> supported by DP. >>> >>> Changes in v5: >>> -- revert changes at sc7180.dtsi and sc7280.dtsi >>> -- add &dp_out to sc7180-trogdor.dtsi and sc7280-herobrine.dtsi >>> >>> Changes in v6: >>> -- add data-lanes and link-frequencies to yaml >>> >>> Changes in v7: >>> -- change 160000000 to 1620000000 >>> -- separate yaml to different patch >>> >>> Changes in v8: >>> -- correct Bjorn mail address to kernel.org >>> >>> Changes in v9: >>> -- use symbol rate (hz) for link-frequencies at dp_out at sc7180_trogdor.dtsi >>> >>> Changes in v13: >>> -- delete an extra space at data-lanes >>> >>> Signed-off-by: Kuogee Hsieh <quic_khsieh@xxxxxxxxxxx> >>> --- >>> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 6 +++++- >>> arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 4 ++++ >>> 2 files changed, 9 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi >>> index eae22e6..e2783dd 100644 >>> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi >>> @@ -814,7 +814,11 @@ hp_i2c: &i2c9 { >>> status = "okay"; >>> pinctrl-names = "default"; >>> pinctrl-0 = <&dp_hot_plug_det>; >>> - data-lanes = <0 1>; >>> +}; >>> + >>> +&dp_out { >>> + data-lanes = <0 1>; >>> + link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000>; >> Messed order of nodes. > > can you please give me more details and how should i fixed it? Node overrides/extends are more or less ordered by name. dp should not be around mdp, but for example dsi. Best regards, Krzysztof