Re: [PATCH v4 0/2] Make ILI9486 driver working with 16-bits SPI controllers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 19/12/22 19:13, Neil Armstrong wrote:
Hi Kamlesh,

On 19/12/2022 10:02, Carlo Caione wrote:
This patchset is trying to fix problems seen on S905X boards when interfacing
with an ILI9486 equipped SPI panel.

I fully reviewed both patches, but I'd like a review from the maintainer,
can you have a look ?

Thanks,
Neil

Please accept my apologies for not reviewing for long time.
I do read mails, but couldn't reply because of broken inline reply setup.

There are actually many displays using ili9486, with all having some minute
differences. Waveshare has two version A and B for 3.5 inch LCDs both with ili9486.
The B version needs different initialization sequence and there are few from other vendors.
I have got few mails directly, that the lcd with ili9486 is not working with this driver,
the conclusion is always the slight difference in hardware and thus slight change in driver to get it
working

My point is, if this patchset doesn't break the existing setup, we are good to go.

Both patches look good to me.

Reviewed-by: Kamlesh Gurudasani <kamlesh.gurudasani@xxxxxxxxx>

...

Regards,
Kamlesh


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux