On 12/16/22 18:46, Thomas Zimmermann wrote: > Change struct fb_ops.release and its implementations to not return > a value. Returing an error is not necessary and callers of the > function ignore it. It is also good practice to make clean-up code > unable ot fail, as such failure cannot be handled. typo here "to fail", but I think that you can just fix it when applying. > > In several places drivers tested for the correctness of the internal > reference counting and failed silently if the counter was incorrect. > This would be an error in the implementation, which would require > fixing. So change these tests to return no error, but print a warning. > > v2: > * update omapfb2 (kernel test robot) > > Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx> > --- Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
