On 14.12.22 13:58, Jagan Teki wrote:
> Samsung MIPI DSIM controller is common DSI IP that can be used
> in various SoCs like Exynos, i.MX8M Mini/Nano/Plus.
>
> Add hw_type enum via platform_data so that accessing the different
> controller data between various platforms becomes easy and meaningful.
>
> Suggested-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>
> ---
> Changes for v10:
> - split from previous series patch
> "drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge"
> - update enum type names
>
> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 84 ++++++++++++++++++++-----
> 1 file changed, 69 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> index 7a845badb1b2..fdaf514b39f2 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> @@ -254,6 +254,16 @@ struct exynos_dsi_transfer {
> #define DSIM_STATE_CMD_LPM BIT(2)
> #define DSIM_STATE_VIDOUT_AVAILABLE BIT(3)
>
> +enum exynos_dsi_type {
> + DSIM_TYPE_EXYNOS3250,
> + DSIM_TYPE_EXYNOS4210,
> + DSIM_TYPE_EXYNOS5410,
> + DSIM_TYPE_EXYNOS5422,
> + DSIM_TYPE_EXYNOS5433,
> +
The empty line looks a bit awkward to me. Otherwise:
Reviewed-by: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx>
> + DSIM_TYPE_COUNT,
> +};
> +
[...]
