Re: [PATCH v2] drm/etnaviv: Remove redundant dev_err()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2022년 12월 12일 (월) 오후 3:14, Kang Minchul <tegongkang@xxxxxxxxx>님이 작성:
>
> Function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> Signed-off-by: Kang Minchul <tegongkang@xxxxxxxxx>
> ---
> Changes in v2:
>   - Removed unnecessary braces.
>
>  drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> index a31eeff2b297..6dbe0c45b695 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> @@ -1770,10 +1770,8 @@ static int etnaviv_gpu_platform_probe(struct platform_device *pdev)
>
>         /* Get Interrupt: */
>         gpu->irq = platform_get_irq(pdev, 0);
> -       if (gpu->irq < 0) {
> -               dev_err(dev, "failed to get irq: %d\n", gpu->irq);
> +       if (gpu->irq < 0)
>                 return gpu->irq;
> -       }
>
>         err = devm_request_irq(&pdev->dev, gpu->irq, irq_handler, 0,
>                                dev_name(gpu->dev), gpu);
> --
> 2.34.1
>

I guess problem dealt with by this patch have already been resolved in the past.
I think I worked on the wrong branch.

Please ignore this patch.
Sorry for your inconvenience.

Regards,
Kang Minchul




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux