On Sun, Dec 11, 2022 at 3:02 PM Kang Minchul <tegongkang@xxxxxxxxx> wrote: > > Function dev_err() is redundant because platform_get_irq() > already prints an error. > > Signed-off-by: Kang Minchul <tegongkang@xxxxxxxxx> > --- > drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c > index a31eeff2b297..097fa9034ee8 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c > +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c > @@ -1771,7 +1771,6 @@ static int etnaviv_gpu_platform_probe(struct platform_device *pdev) > /* Get Interrupt: */ > gpu->irq = platform_get_irq(pdev, 0); > if (gpu->irq < 0) { > - dev_err(dev, "failed to get irq: %d\n", gpu->irq); > return gpu->irq; > } If the dev_err() line is removed, then the { and } should be removed as well.