On Mon, 2022-12-05 at 17:19 -0800, Ceraolo Spurio, Daniele wrote: > On MTL the GSC FW needs to be loaded on the media GT by the graphics > driver. We're going to treat it like a new uc_fw, so add the initial > defs and init/fini functions for it. > > Similarly to the other FWs, the GSC FW path can be overriden via > modparam. The modparam can also be used to disable the GSC FW loading by > setting it to an empty string. > > Note that the new structure has been called intel_gsc_uc to avoid > confusion with the existing intel_gsc, which instead represents the heci > gsc interfaces. > > v2: re-order Makefile list to be properly sorted (Jani, Alan), better > comment (alan) > Alan:[snip] As per offline conversation, i re-reviewed the difference from Rev1 to Rev2 - i.e. just the makefile and the comment changes, all looks good, so: Reviewed-by: Alan Previn <alan.previn.teres.alexis@xxxxxxxxx>