Hi Am 06.12.22 um 10:41 schrieb Neil Armstrong:
Hi Carlo, On 06/12/2022 09:34, Carlo Caione wrote:For platforms using simplefb / efifb, call drm_aperture_remove_framebuffers() to remove the conflicting framebuffer.Conflicting framebuffer on the SPI display ? How is that possible ?
Calling drm_aperture_remove_framebuffers() is only required if the graphics card may have been pre-initialized by the system, such as a VGA-compatible card on a PC.
Could the SPI display have been initialized by the firmware? If not, the call should be left out.
Best regards Thomas
The meson_drm should already do this, no ? NeilSigned-off-by: Carlo Caione <ccaione@xxxxxxxxxxxx> --- drivers/gpu/drm/tiny/ili9486.c | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/drivers/gpu/drm/tiny/ili9486.c b/drivers/gpu/drm/tiny/ili9486.cindex 14a9e6ad2d15..6fd4d42437fd 100644 --- a/drivers/gpu/drm/tiny/ili9486.c +++ b/drivers/gpu/drm/tiny/ili9486.c @@ -14,6 +14,7 @@ #include <video/mipi_display.h> +#include <drm/drm_aperture.h> #include <drm/drm_atomic_helper.h> #include <drm/drm_drv.h> #include <drm/drm_fb_helper.h> @@ -238,6 +239,10 @@ static int ili9486_probe(struct spi_device *spi) if (ret) return ret; + ret = drm_aperture_remove_framebuffers(false, &ili9486_driver); + if (ret) + return ret; + drm_mode_config_reset(drm); ret = drm_dev_register(drm, 0);
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
