Re: [PATCH v6 1/4] arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/12/2022 19:34, Kuogee Hsieh wrote:

On 11/30/2022 4:07 PM, Dmitry Baryshkov wrote:
On 01/12/2022 01:51, Kuogee Hsieh wrote:
Move data-lanes property from mdss_dp node to dp_out endpoint. Also
add link-frequencies property into dp_out endpoint as well. The last
frequency specified at link-frequencies will be the max link rate
supported by DP.

Changes in v5:
-- revert changes at sc7180.dtsi and sc7280.dtsi
-- add &dp_out to sc7180-trogdor.dtsi and sc7280-herobrine.dtsi

Changes in v6:
-- add data-lanes and link-frequencies to yaml

Signed-off-by: Kuogee Hsieh <quic_khsieh@xxxxxxxxxxx>
---
  .../devicetree/bindings/display/msm/dp-controller.yaml  | 17 +++++++++++++++++

Separate patch. Also you didn't check the get_maintainers output, so required parties were not included into the distribution.

Also as you'd check the get_maintainers output, please fix other email addresses too.

arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi            |  6 +++++-
  arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi          |  6 +++++-
  3 files changed, 27 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
index 94bc6e1..af70343 100644
--- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
@@ -90,6 +90,20 @@ properties:
          $ref: /schemas/graph.yaml#/properties/port
          description: Output endpoint of the controller
  +        properties:
+          endpoint:
+            $ref: /schemas/media/video-interfaces.yaml#
+
+          properties:
+            link-frequencies: true
+            data-lanes: true

No. Use $ref for both of them.

+
+          required:
+            - link-frequencies
+            - data-lanes

No, they are not required.

+
+          additionalProperties: false
+

deprecation of old data-lanes property?
there is no old data-lanes property.

There is one:

$ grep -n data-lanes Documentation/devicetree/bindings/display/msm/dp-controller.yaml
82:  data-lanes:


--
With best wishes
Dmitry




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux