Re: [PATCH] drm/tests: probe_helper: Fix unitialized variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/1/22 10:07, Maxime Ripard wrote:
> The len variable is used while uninitialized. Initialize it.
> 
> Fixes: 1e4a91db109f ("drm/probe-helper: Provide a TV get_modes helper")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx>
> ---
>  drivers/gpu/drm/tests/drm_probe_helper_test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/tests/drm_probe_helper_test.c b/drivers/gpu/drm/tests/drm_probe_helper_test.c
> index 7e938258c742..211131405500 100644
> --- a/drivers/gpu/drm/tests/drm_probe_helper_test.c
> +++ b/drivers/gpu/drm/tests/drm_probe_helper_test.c
> @@ -115,6 +115,7 @@ drm_test_connector_helper_tv_get_modes_check(struct kunit *test)
>  	ret = drm_connector_helper_tv_get_modes(connector);
>  	KUNIT_EXPECT_EQ(test, ret, params->num_expected_modes);
>  
> +	len = 0;

I would probably do `size_t len = 0;` instead but don't have a strong opinion.

Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux