Re: [PATCH] gpu: host1x: Remove redundant null checks before kfree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/1/22 03:55, zys.zljxml@xxxxxxxxx wrote:
From: Yushan Zhou <katrinzhou@xxxxxxxxxxx>

Fix the following coccicheck warning:
./drivers/gpu/host1x/fence.c:97:2-7: WARNING:
NULL check before some freeing functions is not needed.

Signed-off-by: Yushan Zhou <katrinzhou@xxxxxxxxxxx>
---
  drivers/gpu/host1x/fence.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/host1x/fence.c b/drivers/gpu/host1x/fence.c
index ecab72882192..05b36bfc8b74 100644
--- a/drivers/gpu/host1x/fence.c
+++ b/drivers/gpu/host1x/fence.c
@@ -93,8 +93,7 @@ static void host1x_syncpt_fence_release(struct dma_fence *f)
  {
  	struct host1x_syncpt_fence *sf = to_host1x_fence(f);
- if (sf->waiter)
-		kfree(sf->waiter);
+	kfree(sf->waiter);
dma_fence_free(f);
  }

I disagree with this coccinelle rule; I think it obfuscates from the reader the fact that the pointer could be NULL.

Mikko



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux