> diff --git a/drivers/pwm/pwm-rockchip.c b/drivers/pwm/pwm-rockchip.c > index a5af859217c1..3ec7d1756903 100644 > --- a/drivers/pwm/pwm-rockchip.c > +++ b/drivers/pwm/pwm-rockchip.c > @@ -57,9 +57,9 @@ static inline struct rockchip_pwm_chip *to_rockchip_pwm_chip(struct pwm_chip *c) > return container_of(c, struct rockchip_pwm_chip, chip); > } > > -static void rockchip_pwm_get_state(struct pwm_chip *chip, > - struct pwm_device *pwm, > - struct pwm_state *state) > +static int rockchip_pwm_get_state(struct pwm_chip *chip, > + struct pwm_device *pwm, > + struct pwm_state *state) > { > struct rockchip_pwm_chip *pc = to_rockchip_pwm_chip(chip); > u32 enable_conf = pc->data->enable_conf; > @@ -70,11 +70,11 @@ static void rockchip_pwm_get_state(struct pwm_chip *chip, > > ret = clk_enable(pc->pclk); > if (ret) > - return; > + return 0; > > ret = clk_enable(pc->clk); > if (ret) > - return; > + return 0; > > clk_rate = clk_get_rate(pc->clk); > > @@ -96,6 +96,8 @@ static void rockchip_pwm_get_state(struct pwm_chip *chip, > > clk_disable(pc->clk); > clk_disable(pc->pclk); > + > + return 0; > } for the Rockchip-part: Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx>