On Tue, Nov 29, 2022 at 02:23:04PM +0200, Laurent Pinchart wrote: > Hi Maxime and Chris, > > Thank you for the patch. > > On Thu, Oct 20, 2022 at 10:30:45AM +0200, Maxime Ripard wrote: > > From: Chris Morgan <macromorgan@xxxxxxxxxxx> > > > > Add the MEDIA_BUS_FMT_RGB565_1X24_CPADHI format used by the Geekworm > > MZP280 panel for the Raspberry Pi. > > > > Signed-off-by: Chris Morgan <macromorgan@xxxxxxxxxxx> > > Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > > --- > > .../userspace-api/media/v4l/subdev-formats.rst | 37 ++++++++++++++++++++++ > > include/uapi/linux/media-bus-format.h | 3 +- > > 2 files changed, 39 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/userspace-api/media/v4l/subdev-formats.rst b/Documentation/userspace-api/media/v4l/subdev-formats.rst > > index d21d532eee15..1e61c02aa788 100644 > > --- a/Documentation/userspace-api/media/v4l/subdev-formats.rst > > +++ b/Documentation/userspace-api/media/v4l/subdev-formats.rst > > @@ -986,6 +986,43 @@ The following tables list existing packed RGB formats. > > - g\ :sub:`2` > > - g\ :sub:`1` > > - g\ :sub:`0` > > + * .. _MEDIA-BUS-FMT-RGB565-1X24_CPADHI: > > + > > + - MEDIA_BUS_FMT_RGB565_1X24_CPADHI > > + - 0x1022 > > + - > > + - > > + - > > + - > > + - > > + - > > + - > > + - > > + - > > + - 0 > > + - 0 > > + - 0 > > + - r\ :sub:`4` > > + - r\ :sub:`3` > > + - r\ :sub:`2` > > + - r\ :sub:`1` > > + - r\ :sub:`0` > > + - 0 > > + - 0 > > + - g\ :sub:`5` > > + - g\ :sub:`4` > > + - g\ :sub:`3` > > + - g\ :sub:`2` > > + - g\ :sub:`1` > > + - g\ :sub:`0` > > + - 0 > > + - 0 > > + - 0 > > + - b\ :sub:`4` > > + - b\ :sub:`3` > > + - b\ :sub:`2` > > + - b\ :sub:`1` > > + - b\ :sub:`0` > > * .. _MEDIA-BUS-FMT-RGB666-1X24_CPADHI: > > > > - MEDIA_BUS_FMT_RGB666_1X24_CPADHI > > diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h > > index ec3323dbb927..b0a945eb7040 100644 > > --- a/include/uapi/linux/media-bus-format.h > > +++ b/include/uapi/linux/media-bus-format.h > > @@ -34,13 +34,14 @@ > > > > #define MEDIA_BUS_FMT_FIXED 0x0001 > > > > -/* RGB - next is 0x1022 */ > > +/* RGB - next is 0x1023 */ > > #define MEDIA_BUS_FMT_RGB444_1X12 0x1016 > > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001 > > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002 > > #define MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE 0x1003 > > #define MEDIA_BUS_FMT_RGB555_2X8_PADHI_LE 0x1004 > > #define MEDIA_BUS_FMT_RGB565_1X16 0x1017 > > +#define MEDIA_BUS_FMT_RGB565_1X24_CPADHI 0x1022 I spoke a bit too fast, this should go down with the other 1X24 formats. The Rb tag still holds with this fixed. > > #define MEDIA_BUS_FMT_BGR565_2X8_BE 0x1005 > > #define MEDIA_BUS_FMT_BGR565_2X8_LE 0x1006 > > #define MEDIA_BUS_FMT_RGB565_2X8_BE 0x1007 > > -- Regards, Laurent Pinchart
