Hello Uwe, Thanks for your patch. On 9/12/22 11:15, Uwe Kleine-König wrote: > While working on a drm driver that doesn't need the i2c algobit stuff I > noticed that DRM selects this code even tough only 8 drivers actually use > it. While also only some drivers use i2c, keep the select for I2C for the > next cleanup patch. Still prepare this already by also selecting I2C for > the individual drivers. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > --- Makes sense to me. It would be good to drop this dependency, specially now that many distros have CONFIG_DRM=y to use simpledrm for early boot. > Changes since v1 > (20210514100142.1182997-1-u.kleine-koenig@xxxxxxxxxxxxxx) from > 2021-05-14: > > - rebased to next-20220909 > was something around v5.13-rc2 before, required to fix context > changes in the nouveau Kconfig file. git am -3 handled it just fine. > > I reverified that no new drivers were added that need a corresponding > select. > > Best regards > Uwe > > drivers/gpu/drm/Kconfig | 5 ++++- > drivers/gpu/drm/ast/Kconfig | 2 ++ > drivers/gpu/drm/gma500/Kconfig | 2 ++ > drivers/gpu/drm/hisilicon/hibmc/Kconfig | 2 ++ > drivers/gpu/drm/i915/Kconfig | 2 ++ > drivers/gpu/drm/mgag200/Kconfig | 2 ++ > drivers/gpu/drm/nouveau/Kconfig | 2 ++ > 7 files changed, 16 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index 198ba846d34b..593d7335b10a 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -13,7 +13,6 @@ menuconfig DRM > select HDMI > select FB_CMDLINE > select I2C Is I2C still required or was just a dependency of I2C_ALGOBIT ? I'll wait a few days in case others want to review this change too and then can push this to drm-misc-next. Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
