Hi,
On Fri, Nov 25, 2022 at 09:31:10PM +0100, Geert Uytterhoeven wrote:
> +// FIXME create dynamically from atari_drm_modes[]?
Not necessarily, but they should have proper descriptors at the very least.
> +static const struct drm_named_mode atari_drm_named_modes[] =
> +{
> + { .name = "st-low" },
> + { .name = "st-mid" },
> + { .name = "st-high" },
> + { .name = "tt-low" },
> + { .name = "tt-mid" },
> + { .name = "tt-high" },
> + { .name = "vga" },
> + { .name = "vga70" },
> + { .name = "qvga" },
> + { .name = "hvga" },
> + { .name = "falh" },
> + { /* sentinel */ }
> +};
I'm really not convinced about per-driver named modes. This will only
lead to each driver having its own set of undocumented and obscure mode
names that will just make everything work.
And some of them in that list are completely generic: VGA, QVGA, HVGA at
least should definitely be part of the generic named modes.
Maxime
Attachment:
signature.asc
Description: PGP signature
